Wrap kaldi_pybind to kaldi package. #3815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now everything lives in the `kaldi` package and the user does not need to use `kaldi_pybind` any more.
Contributor
Author
danpovey
reviewed
Jan 6, 2020
| sys.path.insert(0, os.path.dirname(__file__)) | ||
|
|
||
| from kaldi_pybind import * | ||
|
|
Contributor
There was a problem hiding this comment.
I suppose there are going to be a lot of decisions about which things to put in the global kaldi namespace. But it's OK.
Contributor
Author
There was a problem hiding this comment.
There are lots of classes in kaldi_pybind and it is a pain to list each one explicitly.
Contributor
There was a problem hiding this comment.
Sure, that's OK; kaldi is just a thin wrapper for kaldi_pybind. I was actually talking about the lines below, where you import things like Matrix. But as I said, it's OK.
Contributor
|
anyway this looks fine; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now everything lives in the
kaldipackage and the userdoes not need to use
kaldi_pybindany more.