Skip to content

Few suggestions for improvement of SignCheck module #12

@ms-github

Description

@ms-github

Hi,
Please fix the following issues:

  1. In the code, SignCheck/index.js the function checkWinSync() invokes "CheckSign.exe" with command line but never captures the return error/success code from the binary. Maybe the exe wasn't written to return any. I think it would be better to return error code from CheckSign rather than just returning true or false.
  2. CheckSign.exe appears to be generated on VS2015 and compiled with dynamic linkage to CRT. Please update the actual binary to be statically compiled with CRT. VCRUNTIME140.dll will be missing by default on Win7/8.1 systems and hence the exe can't be invoked (missing dependency). This works fine on Win 10 since it has VCRT140.dll by default. Also, Win 7 x64 gets this dll after Windows update. So this should be fixed.
    c_users_ravi_appdata_local_packages_microsoft skypeapp_kzf8qxf38zg5c_localstate_08922712-2652-430d-99cd-409223b56c33

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions