refactor: Convert hover handler to a system

[mflerackers]

Please describe what issue(s) this PR fixes.

Summary

• Changeloged

[dragoncoder047]

Shouldn't this be fakeMouseHover or is it intentionally wrong

Also, return if fake mouse exists?

[mflerackers]

right

[mflerackers]

Can't you use fakeMouse and Mouse together?

[mflerackers]

They have their own closure because I thought they can be used simultaneously.

[dragoncoder047]

Idk, I think the intention was that if the game used fake mouse then the fake mouse object will move to always follow the real mouse, so the hover handler should not run twice in that case.

Also, the hover handler is given the world position, and toWorld converts from screen space to world space, but the fakeMouse.pos is already world space right? At least it won't be screen space if the camera transform is not the identity

[dragoncoder047]

It should

[mflerackers]

update(this: FakeMouse) {
            if (this.pos.x !== lastPos.x || this.pos.y !== lastPos.y) {
                this.trigger("fakeMouseMove", this.pos.clone()); // TODO: Create a deltaPos
            }

It doesn't pass world coordinates to its trigger, so if it is not in root, it's not working as expected.

[dragoncoder047]

The fakeMouseMove event is new, not surprising that it's wrong in places, but also good cause it's unlikely someone is using this extremely unfinished branch just for that event

[mflerackers]

It's not in this branch, it's been there since fakemouse.

[mflerackers]

It's not in this branch, it's been there since fakemouse.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/kaplayjs/kaplay@986

commit: 4a3c1ac