Skip to content

Conversation

@mensfeld
Copy link
Member

@mensfeld mensfeld commented Jul 30, 2025

close #647

@mensfeld mensfeld requested a review from Copilot July 30, 2025 17:01
@mensfeld mensfeld self-assigned this Jul 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for ARM64 GNU precompilation to the rdkafka Ruby gem, enabling faster installation and broader compatibility on ARM64 Linux systems.

  • Bumps version from 0.22.2 to 0.22.3 to include the new ARM64 support
  • Introduces a comprehensive build script for creating self-contained librdkafka.so on Linux aarch64 GNU
  • Adds GitHub Actions CI workflow for testing both compilation-from-source and precompiled binary flows on ARM64

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
lib/rdkafka/version.rb Version bump to 0.22.3
ext/build_linux_aarch64_gnu.sh New comprehensive build script for ARM64 GNU with dependency management and security features
CHANGELOG.md Documents the new ARM64 GNU precompilation support
.github/workflows/ci_linux_aarch64_gnu.yml GitHub Actions workflow for ARM64 CI testing across Ubuntu versions and Ruby versions
Comments suppressed due to low confidence (4)

.github/workflows/ci_linux_aarch64_gnu.yml:68

  • JRuby 10.0 does not exist. The latest stable JRuby version is 9.x series. This should likely be 'jruby-9.4' or similar.
          - 'jruby-10.0'

.github/workflows/ci_linux_aarch64_gnu.yml:73

  • JRuby 10.0 does not exist. The latest stable JRuby version is 9.x series. This should likely be 'jruby-9.4' or similar.
          - ruby: 'jruby-10.0'

.github/workflows/ci_linux_aarch64_gnu.yml:63

  • Ruby 3.5.0-preview1 may not exist yet. Ruby 3.4 was recently released, and preview versions should be verified to exist before being used in CI.
          - '3.5.0-preview1'

.github/workflows/ci_linux_aarch64_gnu.yml:190

  • Ruby 3.5.0-preview1 may not exist yet. Ruby 3.4 was recently released, and preview versions should be verified to exist before being used in CI.
          - '3.5.0-preview1'

@mensfeld mensfeld marked this pull request as ready for review July 31, 2025 11:02
@mensfeld mensfeld merged commit 6e7a577 into main Jul 31, 2025
78 checks passed
@mensfeld mensfeld deleted the aarch64 branch July 31, 2025 11:55
mensfeld added a commit to karafka/karafka-rdkafka that referenced this pull request Jul 31, 2025
* aarch64

* Update CHANGELOG.md



* temp disable

* fix runner type

* add release script for aarch64

* stabilize spec

* remarks

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Once precompiled extensions stabilize, consider supporting ARM64 Gnu

2 participants