-
-
Notifications
You must be signed in to change notification settings - Fork 122
aarch64 #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for ARM64 GNU precompilation to the rdkafka Ruby gem, enabling faster installation and broader compatibility on ARM64 Linux systems.
- Bumps version from 0.22.2 to 0.22.3 to include the new ARM64 support
- Introduces a comprehensive build script for creating self-contained librdkafka.so on Linux aarch64 GNU
- Adds GitHub Actions CI workflow for testing both compilation-from-source and precompiled binary flows on ARM64
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/rdkafka/version.rb | Version bump to 0.22.3 |
| ext/build_linux_aarch64_gnu.sh | New comprehensive build script for ARM64 GNU with dependency management and security features |
| CHANGELOG.md | Documents the new ARM64 GNU precompilation support |
| .github/workflows/ci_linux_aarch64_gnu.yml | GitHub Actions workflow for ARM64 CI testing across Ubuntu versions and Ruby versions |
Comments suppressed due to low confidence (4)
.github/workflows/ci_linux_aarch64_gnu.yml:68
- JRuby 10.0 does not exist. The latest stable JRuby version is 9.x series. This should likely be 'jruby-9.4' or similar.
- 'jruby-10.0'
.github/workflows/ci_linux_aarch64_gnu.yml:73
- JRuby 10.0 does not exist. The latest stable JRuby version is 9.x series. This should likely be 'jruby-9.4' or similar.
- ruby: 'jruby-10.0'
.github/workflows/ci_linux_aarch64_gnu.yml:63
- Ruby 3.5.0-preview1 may not exist yet. Ruby 3.4 was recently released, and preview versions should be verified to exist before being used in CI.
- '3.5.0-preview1'
.github/workflows/ci_linux_aarch64_gnu.yml:190
- Ruby 3.5.0-preview1 may not exist yet. Ruby 3.4 was recently released, and preview versions should be verified to exist before being used in CI.
- '3.5.0-preview1'
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
close #647