Skip to content

Conversation

@mensfeld
Copy link
Member

this PR aligns the testing and quality complementary pipelines between rdkafka and the karafka fork

@mensfeld mensfeld requested a review from Copilot August 16, 2025 13:30
@mensfeld mensfeld self-assigned this Aug 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aligns the testing and quality complementary pipelines between rdkafka and the karafka fork by introducing SSL testing capabilities, improving build scripts with symbol export controls, and establishing comprehensive CI workflows.

  • Adds SSL certificate generation and Docker Compose SSL configuration for testing encrypted connections
  • Improves build scripts with symbol export maps to limit exposed symbols in precompiled libraries
  • Introduces complementary CI workflows for extended testing across multiple distributions and architectures

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ext/generate-ssl-certs.sh Adds script to generate SSL certificates for Kafka testing
ext/build_*.sh Updates build scripts with symbol export controls and library improvements
docker-compose-ssl.yml Adds Docker Compose configuration for SSL-enabled Kafka testing
.github/workflows/ci_*.yml Updates CI workflows with SSL testing and adds complementary testing pipelines
ext/build_common.sh Updates librdkafka version and improves source distribution handling
CHANGELOG.md Documents new features and improvements
Comments suppressed due to low confidence (4)

ext/build_linux_aarch64_gnu.sh:268

  • This line appears to be incorrectly prefixed with spaces and a minus sign, making it unreachable code. It should be removed as the corrected version follows on line 279.
# Write the export map

ext/build_common.sh:360

  • This commented-out line appears to be incorrectly prefixed with spaces and a minus sign, making it unreachable code. It should be removed completely since it's been replaced by the MIT mirror URL.
    # Using MIT mirror since kerberos.org is down

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mensfeld mensfeld marked this pull request as ready for review August 16, 2025 20:16
@mensfeld mensfeld merged commit 62397f5 into main Aug 16, 2025
183 of 187 checks passed
@mensfeld mensfeld deleted the sync-oses branch August 16, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants