Conversation
added 2 commits
January 4, 2022 18:25
also move _example to 0_example since gopls doesn't like the _example directory name.
Collaborator
|
Meh, screwed up my branch. Check out 6d69693 |
Collaborator
|
As mentioned in discord, I think generation might be best for this, if at all. Generics attempt was pain. |
Owner
Author
|
Seems like the case, yeah, My efforts are currently focused around #7, but will come back to that once I'm done. Open to any other suggestions, truthfully, the generics part was a good idea from a user POV, but it's an ugly and non-extensible hack. |
jolheiser
reviewed
Jan 5, 2022
jolheiser
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also move _example to 0_example since gopls doesn't like the _example directory name.