sometimes callback is not called #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This change makes a lot of sense if there are some weird behaviours when debounce is 0. I've only used this with debounce values 100-500. Good catch! |
karl-run
added a commit
that referenced
this pull request
Jul 13, 2018
Owner
|
I have released 1.3.0 with your changes. |
Contributor
Author
|
wow! super fast!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @karl-run , thanks for useful component.
I'm using your component to implement the infinite scroll.
I found that the callback is not called sometimes even if
debounceis set to 0(ms) or like 1(ms).I'm not sure why callback is not invoked though,
but it works perfect if without using lodash.
So, I made PR to skip lodash implementation if
debounceis set to 0.could you accept this ?
thank you.