Conversation
…bar settings browser test
ugh. tried everything, but seems that async imports work the best for proper chunk splitting
- handles dependencies correctly, only options page code is remaining in options_page.js
- force naming chunks is nice cause they end up with random numeric names in optimized build
- still don't understand how it works without including codemirror.js into the html page
also tried
- static import + splitting chunks like this
cacheGroups: {
codemirror: {
test: /[\\/]node_modules[\\/].*codemirror/,
name: 'codemirror',
chunks: 'all',
},
},
this works, but doesn't split out dependencies of codemirror?
so still end up with some crap in options_page.js
- specifying codemirror entry point and adding to dependsOn
'codemirror': {
// TODO no need for codemirror source map??
import: [
"codemirror",
"@codemirror/view",
"@codemirror/language",
"@codemirror/search",
"@codemirror/autocomplete",
"@codemirror/state",
"@codemirror/lang-css",
"@codemirror/lang-javascript",
],
}
this splits out everything properly... but then options page failed loading another chunk, webext-options-sync
no idea why, couldn't figure out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.