conditionally run extension build command in windows/linux#399
Merged
karlicoss merged 2 commits intokarlicoss:masterfrom Jul 15, 2023
Merged
conditionally run extension build command in windows/linux#399karlicoss merged 2 commits intokarlicoss:masterfrom
karlicoss merged 2 commits intokarlicoss:masterfrom
Conversation
karlicoss
requested changes
Jul 10, 2023
Owner
karlicoss
left a comment
karlicoss
left a comment
There was a problem hiding this comment.
Sorry, somehow missed the notification! Thanks, it makes sense and looks good, just one comment because it breaks the github CI :)
Owner
|
Hmm another CI error, but I think this is irrelevant to your changes, I'll investigate |
Owner
|
fixed the shebang issue since I had to rebase on top of latest master anyway -- everything looks good now. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as mentioned in Issue #398, this change conditionally runs the build command based on the user's OS