Skip to content

Conversation

@ladal1
Copy link

@ladal1 ladal1 commented Feb 10, 2021

Říkal jsem si že než budu pokračovat tak ti to sem postnu abys kdyžtak mohl upozornit na problémy apod. než se do toho moc zahrabu 👍

@karlosss
Copy link
Owner

karlosss commented Feb 11, 2021

Desired syntaxe je cca nejak takhle:

actions = {
    "getById": Action(parameters={"id": IntegerType(validators=(IsPositive, ReferencesExistingObject))}, 
                      return_value=ObjectType("self"),
                      validators=SomeAnotherValidator
                      exec_fn=get_by_id)
}

Jak toho docilit:

  • v datatypes.py vyhodit permissions z Type (a pustit testy, podle me je to pohrobek, kdyz testy projdou, je to tak), a misto toho tam pridat validators
  • validators pridat i do Action v actions.py
  • samotnou validaci potom resit podobne jako permissions - to uz jsi cca vymyslel - mel by to byl jeden velky and vsech validatoru

@karlosss
Copy link
Owner

Zaroven prosim oprav toto https://github.com/karlosss/simple_api/blob/master/simple_api/object/actions.py#L21, je potreba to rozdelit na dva forloopy, jeden pres parametry a jeden pres data, tohle vyhodi duplikatni klice (realne se to nestane, ale je to bug) - podobne potom iteruj pres policka, kdyz na nich budes hledat validatory

@ladal1
Copy link
Author

ladal1 commented Feb 11, 2021

"validators pridat i do Action v actions.py" - to už vlastně dělám, jen to trochu upravím aby to fungovalo lépe

@ladal1 ladal1 changed the title [Dummy] Basic validation implementation Basic validation implementation Feb 12, 2021
self.return_value = return_value
self.exec_fn = exec_fn
self.permissions = permissions or ()
self.action_validators = validators or ()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potencialne prejmenovat pouze na self.validators

…a now, actions argument parsing renamed for better readability
@ladal1 ladal1 requested a review from karlosss February 13, 2021 19:49
@karlosss karlosss merged commit be4051f into karlosss:generate-frontend Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants