Skip to content

Conversation

@RainbowMango
Copy link
Member

This PR syncs APIs from karmada-io/karmada release v1.12.0.

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 4, 2025
@RainbowMango RainbowMango requested a review from Copilot March 4, 2025 12:12
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR synchronizes APIs from the karmada-io/karmada release v1.12.0 by updating API types, deep copy functions, and related bindings. Key changes include the introduction of new types (e.g., CustomCertificate, FieldOverrider, and StatePreservation), updates to graceful eviction task options with new PurgeMode and state preservation fields, and various comment and grammatical improvements across cluster and API definitions.

Reviewed Changes

File Description
operator/v1alpha1/register.go New registration file for operator v1alpha1 APIs.
policy/v1alpha1/override_types.go Added FieldOverrider type and updated Overriders struct with new field.
operator/v1alpha1/type.go Introduced CustomCertificate and updated ExternalEtcd and API server spec.
policy/v1alpha1/propagation_types.go Added PreserveResourcesOnDeletion and state preservation related types.
zz_generated.deepcopy.go (multiple files) Updated deep copy implementations to cover new fields and types.
work/v1alpha2/binding_types.go Added PreserveResourcesOnDeletion and PurgeMode fields to binding types.
work/v1alpha2/binding_types_helper*.go Extended graceful eviction task options to support new fields.
cluster/(v1alpha1/types.go, types.go) Minor comment updates and grammatical corrections in cluster API types.
config/v1alpha1/resourceinterpreterwebhook_types.go Minor comment improvements.
operator/constants/constants.go Removed obsolete constants file.

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

policy/v1alpha1/override_types.go:136

  • [nitpick] Consider renaming the field and JSON tag to 'FieldOverriders' (plural) for consistency with the other overrider fields (e.g., AnnotationsOverrider) to improve clarity.
FieldOverrider []FieldOverrider `json:"fieldOverrider,omitempty"`

@RainbowMango RainbowMango requested a review from Copilot March 4, 2025 12:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR synchronizes the APIs from the karmada repository release v1.12.0. The changes include adding new API registration and type definitions (e.g. FieldOverrider in policy and CustomCertificate in operator), updating generated deepcopy functions across multiple packages, and refining documentation and comments for clarity.

Reviewed Changes

File Description
operator/v1alpha1/register.go New file for registering operator APIs
policy/v1alpha1/override_types.go Added FieldOverrider type and updated comments
policy/v1alpha1/propagation_types.go Introduced PreserveResourcesOnDeletion and state preservation rules
operator/v1alpha1/type.go Added CustomCertificate & updated ExternalEtcd fields
Various zz_generated.deepcopy.go files Updated auto-generated deepcopy functions
work/v1alpha2/binding_types.go & binding_types_helper* Added PurgeMode and related task options for eviction tasks
cluster/* and config/* files Minor comment and wording improvements in API types
operator/constants/constants.go Removed constants file

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

operator/constants/constants.go:1

  • The entire constants file has been removed; please verify that all references to these constants have been updated or migrated to ensure no unresolved dependencies remain.
package constants

operator/v1alpha1/zz_generated.deepcopy.go:179

  • This line performs a shallow copy for SecretRef. If LocalSecretReference contains any pointer fields, consider implementing a deep copy to avoid potential unintended mutations.
out.SecretRef = in.SecretRef

@RainbowMango RainbowMango requested a review from Copilot March 4, 2025 12:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR syncs the APIs from the upstream karmada release v1.12.0, updating type definitions, deepcopy functions, and documentation across multiple API groups. Key changes include:

  • Addition of new API types such as CustomCertificate, FieldOverrider, and StatePreservation.
  • Updates to deep copy implementations and new fields on several spec types.
  • Various documentation clarifications and removal of obsolete constant definitions.

Reviewed Changes

File Description
operator/v1alpha1/register.go New registration file for the operator API types.
policy/v1alpha1/override_types.go Added FieldOverrider type and updated Overriders struct.
operator/v1alpha1/type.go Introduced CustomCertificate and extra API server volume fields.
(multiple zz_generated.deepcopy.go files) Synced auto-generated deepcopy functions.
work/v1alpha2/binding_types.go & helper files Added PreserveResourcesOnDeletion and updated eviction task options.
cluster/* files Updated documentation and minor naming corrections.
config/v1alpha1/resourceinterpreterwebhook_types.go Improved comment wording for interpreter operation.
operator/constants/constants.go Removed constants file in line with upstream changes.
policy/v1alpha1/propagation_types.go Added state preservation and updated preservation docs.

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

policy/v1alpha1/override_types.go:136

  • [nitpick] Consider renaming the JSON field to "fieldOverriders" for consistency with other overrider fields (e.g. AnnotationsOverrider) which use plural naming.
FieldOverrider []FieldOverrider `json:"fieldOverrider,omitempty"`

operator/constants/constants.go:1

  • The removal of the operator/constants/constants.go file should be verified to ensure it is intentional, as it may affect parts of the system that rely on these constants.
Entire file removal

@RainbowMango
Copy link
Member Author

cc @chaunceyjiang

@RainbowMango RainbowMango added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 0a396ea into karmada-io:main Mar 6, 2025
2 checks passed
@RainbowMango RainbowMango deleted the pr_sync_120 branch March 6, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants