Skip to content

Conversation

@CharlesQQ
Copy link
Member

@CharlesQQ CharlesQQ commented Apr 25, 2025

What type of PR is this?

What this PR does / why we need it:

When continuously updating the ·spec.suspension.dispatching· field of pp, the field of rb may be inconsistent with pp.

Which issue(s) this PR fixes:
fixes #6379

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2025
@CharlesQQ CharlesQQ force-pushed the pp-rb-inconsistent-fix branch 7 times, most recently from 5083890 to da8c69b Compare April 26, 2025 05:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.85366% with 28 lines in your changes missing coverage. Please review.

Project coverage is 48.55%. Comparing base (c31c8e4) to head (38b8e12).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
pkg/detector/detector.go 63.15% 21 Missing and 7 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6322      +/-   ##
==========================================
+ Coverage   48.44%   48.55%   +0.10%     
==========================================
  Files         677      677              
  Lines       56067    56138      +71     
==========================================
+ Hits        27164    27257      +93     
+ Misses      27123    27096      -27     
- Partials     1780     1785       +5     
Flag Coverage Δ
unittests 48.55% <65.85%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CharlesQQ CharlesQQ force-pushed the pp-rb-inconsistent-fix branch from da8c69b to d6302d2 Compare April 28, 2025 06:42
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2025
@CharlesQQ CharlesQQ force-pushed the pp-rb-inconsistent-fix branch from d6302d2 to 4d9bbc6 Compare April 28, 2025 07:12
Signed-off-by: chang.qiangqiang <chang.qiangqiang@immomo.com>
@CharlesQQ CharlesQQ force-pushed the pp-rb-inconsistent-fix branch from 4d9bbc6 to 38b8e12 Compare April 28, 2025 07:34
@RainbowMango
Copy link
Member

Is this the complete solution for #5996?

@RainbowMango
Copy link
Member

If I remember correctly, we haven't worked out an ideal solution yet, right?
How about talk about it at next community meeting?

@CharlesQQ
Copy link
Member Author

talk about it at next community meeting?

We will discuss this issue at our next community meeting.

@CharlesQQ
Copy link
Member Author

Is this the complete solution for #5996?

No, this PR is only to solve the third case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The fields related to pp and rb may be different

4 participants