-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(detector): fix pp and rb inconsistent #6322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5083890 to
da8c69b
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6322 +/- ##
==========================================
+ Coverage 48.44% 48.55% +0.10%
==========================================
Files 677 677
Lines 56067 56138 +71
==========================================
+ Hits 27164 27257 +93
+ Misses 27123 27096 -27
- Partials 1780 1785 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
da8c69b to
d6302d2
Compare
d6302d2 to
4d9bbc6
Compare
Signed-off-by: chang.qiangqiang <chang.qiangqiang@immomo.com>
4d9bbc6 to
38b8e12
Compare
|
Is this the complete solution for #5996? |
|
If I remember correctly, we haven't worked out an ideal solution yet, right? |
We will discuss this issue at our next community meeting. |
No, this PR is only to solve the third case |
What type of PR is this?
What this PR does / why we need it:
When continuously updating the ·spec.suspension.dispatching· field of pp, the field of rb may be inconsistent with pp.
Which issue(s) this PR fixes:
fixes #6379
Special notes for your reviewer:
Does this PR introduce a user-facing change?: