Skip to content

Rename carrier identifiers#64

Merged
danh91 merged 2 commits intomasterfrom
rename-carrier-identifiers
Jun 6, 2020
Merged

Rename carrier identifiers#64
danh91 merged 2 commits intomasterfrom
rename-carrier-identifiers

Conversation

@danh91
Copy link
Member

@danh91 danh91 commented Jun 5, 2020

Rename carrier identifier keys for clarity

  • renaming: carrier -> carrier_name
  • renaming: carrier_name -> carrier_id
  • update tests
  • bump version to 2020.6.1

@danh91 danh91 self-assigned this Jun 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #64 into master will increase coverage by 0.00%.
The diff coverage is 96.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files         116      116           
  Lines        4783     4786    +3     
  Branches      232      232           
=======================================
+ Hits         4511     4514    +3     
  Misses        224      224           
  Partials       48       48           
Impacted Files Coverage Δ
.../canadapost/purplship/carriers/canadapost/error.py 100.00% <ø> (ø)
...canadapost/purplship/carriers/canadapost/rating.py 94.11% <ø> (ø)
.../carriers/canadapost/shipment/contract_shipment.py 94.87% <ø> (ø)
...riers/canadapost/shipment/non_contract_shipment.py 72.97% <ø> (ø)
.../canadapost/purplship/carriers/canadapost/track.py 100.00% <ø> (ø)
...tensions/dhl/purplship/carriers/dhl/book_pickup.py 100.00% <ø> (ø)
extensions/dhl/purplship/carriers/dhl/dct_quote.py 86.27% <ø> (ø)
extensions/dhl/purplship/carriers/dhl/error.py 100.00% <ø> (ø)
...nsions/dhl/purplship/carriers/dhl/modify_pickup.py 100.00% <ø> (ø)
extensions/dhl/purplship/carriers/dhl/ship_val.py 90.47% <ø> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a9402...30e38cb. Read the comment docs.

@danh91 danh91 force-pushed the rename-carrier-identifiers branch from b91334e to 9a57f7b Compare June 6, 2020 05:53
@danh91 danh91 force-pushed the rename-carrier-identifiers branch from 9a57f7b to 30e38cb Compare June 6, 2020 05:56
@danh91 danh91 merged commit bc6daa7 into master Jun 6, 2020
@danh91 danh91 deleted the rename-carrier-identifiers branch June 6, 2020 05:58
danh91 added a commit that referenced this pull request Oct 20, 2021
[feature] Purplship Server Graph API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants