Skip to content

[feature] self-documented carrier option definition#97

Merged
danh91 merged 3 commits intomainfrom
standardize-carrier-option-definitions
Feb 7, 2021
Merged

[feature] self-documented carrier option definition#97
danh91 merged 3 commits intomainfrom
standardize-carrier-option-definitions

Conversation

@danh91
Copy link
Member

@danh91 danh91 commented Feb 6, 2021

  • designing carrier option definition abstraction
  • update carrier options definitions to pass the tests
  • update docs with options description and types

@danh91 danh91 force-pushed the standardize-carrier-option-definitions branch from a726e74 to 1a1cb69 Compare February 7, 2021 03:06
@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #97 (45c0d6b) into main (6b75176) will decrease coverage by 0.02%.
The diff coverage is 98.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   96.20%   96.18%   -0.03%     
==========================================
  Files         131      131              
  Lines        5114     5136      +22     
  Branches      264      257       -7     
==========================================
+ Hits         4920     4940      +20     
- Misses        136      137       +1     
- Partials       58       59       +1     
Impacted Files Coverage Δ
...urplship/providers/canadapost/shipment/contract.py 96.77% <0.00%> (+1.90%) ⬆️
...ship/providers/canadapost/shipment/non_contract.py 65.51% <0.00%> (-4.76%) ⬇️
purplship/purplship/core/units.py 94.19% <89.65%> (+0.03%) ⬆️
purplship/purplship/core/utils/enum.py 92.68% <96.55%> (+9.34%) ⬆️
.../canadapost/purplship/providers/canadapost/rate.py 85.29% <100.00%> (-8.83%) ⬇️
...canadapost/purplship/providers/canadapost/units.py 100.00% <100.00%> (ø)
...tensions/canpar/purplship/providers/canpar/rate.py 100.00% <100.00%> (ø)
...npar/purplship/providers/canpar/shipment/create.py 100.00% <100.00%> (ø)
...ensions/canpar/purplship/providers/canpar/units.py 100.00% <100.00%> (ø)
...hl_express/purplship/providers/dhl_express/rate.py 78.57% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b75176...45c0d6b. Read the comment docs.

@danh91 danh91 force-pushed the standardize-carrier-option-definitions branch from 1a1cb69 to a37ae36 Compare February 7, 2021 03:21
@danh91 danh91 force-pushed the standardize-carrier-option-definitions branch from 769fe41 to 45c0d6b Compare February 7, 2021 17:01
@danh91 danh91 merged commit 7d17945 into main Feb 7, 2021
@danh91 danh91 deleted the standardize-carrier-option-definitions branch February 7, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant