fix: show detailed error messages for shipment cancellation #972
Merged
danh91 merged 1 commit intopatch-2026.1.13from Feb 20, 2026
Merged
fix: show detailed error messages for shipment cancellation #972danh91 merged 1 commit intopatch-2026.1.13from
danh91 merged 1 commit intopatch-2026.1.13from
Conversation
danh91
added a commit
that referenced
this pull request
Feb 21, 2026
* fix: show detailed error messages for shipment cancellation and status changes (#972) * fix: use correct SendReturnToAddress field name in Landmark ImportRequest The ImportRequest path was using ReturnAddress= which was silently swallowed by **kwargs_ in the GenerateDS constructor, causing return address to be omitted from the XML output. * fix: make shipment is_return field nullable to prevent IntegrityError The is_return column was NOT NULL which caused IntegrityError when creating shipments through code paths that don't explicitly set this field. Making it nullable with default=False resolves the production constraint violation. * release: 2026.1.13 --------- Co-authored-by: Ansh dev nagar <anshdevnagar@gmail.com>
danh91
pushed a commit
that referenced
this pull request
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestErrorstores details inerror.data, noterror.messageerrorToMessagesfrom@karrio/libto extract the actual API error (e.g., "Please cancel this shipment pickup before")