Skip to content

Feature/171 implement point in polygon lookup query#196

Merged
jathavaan merged 7 commits intomainfrom
feature/171-implement-point-in-polygon-lookup-query
Apr 7, 2026
Merged

Feature/171 implement point in polygon lookup query#196
jathavaan merged 7 commits intomainfrom
feature/171-implement-point-in-polygon-lookup-query

Conversation

@jathavaan
Copy link
Copy Markdown
Collaborator

This pull request adds support for a new "point-in-polygon lookup" benchmark for both DuckDB and PostGIS backends. It introduces new entrypoints, updates configuration files to include these benchmarks, and implements the logic for generating and testing points inside and outside polygons. The changes ensure that the new benchmarks are integrated into the workflow, Docker setup, and experiment definitions.

New Benchmark Implementation:

  • Added new entrypoints for point-in-polygon lookup for both DuckDB and PostGIS, including logic for generating test points and running the benchmark. (src/presentation/entrypoints/point_in_polygon_lookup_duckdb.py [1] src/presentation/entrypoints/point_in_polygon_lookup_postgis.py [2]
  • Registered the new entrypoints in the module initializer and dependency injection configuration. (src/presentation/entrypoints/__init__.py [1] src/presentation/configuration/app_config.py [2]

Configuration and Workflow Updates:

  • Added the point-in-polygon lookup benchmarks to the experiment definitions in benchmarks.yml and to the Docker Compose services, making them available for benchmarking runs. (benchmarks.yml [1] docker-compose.yml [2]
  • Updated the GitHub Actions workflow to build and push container images for the new services. (.github/workflows/push-containers-to-acr.yml .github/workflows/push-containers-to-acr.ymlR125-R132)

Benchmark Runner Integration:

  • Integrated the new benchmarks into the benchmark_runner.py dispatch logic and imports, enabling them to be run by script ID. (benchmark_runner.py [1] [2]

Domain Update:

@jathavaan jathavaan self-assigned this Mar 28, 2026
Copilot AI review requested due to automatic review settings March 28, 2026 10:15
@jathavaan jathavaan linked an issue Mar 28, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “point-in-polygon lookup” benchmark to the benchmarking framework, wiring it into runtime entrypoints, dispatch, container builds, and experiment configuration for both DuckDB and PostGIS backends.

Changes:

  • Introduces DuckDB and PostGIS entrypoints implementing point-in-polygon lookup benchmark logic (including point generation).
  • Registers the new benchmarks across DI wiring, benchmark_runner.py dispatch, benchmarks.yml, and Docker Compose/ACR workflow.
  • Extends BenchmarkIteration with a new iteration count for the benchmark.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/presentation/entrypoints/point_in_polygon_lookup_duckdb.py New DuckDB benchmark entrypoint and point generation logic.
src/presentation/entrypoints/point_in_polygon_lookup_postgis.py New PostGIS benchmark entrypoint and point generation logic.
src/presentation/entrypoints/init.py Exposes the new entrypoints for importing/dispatch.
src/presentation/configuration/app_config.py Wires new entrypoint modules into dependency injection.
src/domain/enums/benchmark_iteration.py Adds iteration value for the new benchmark.
docker-compose.yml Adds services to run the new benchmark containers locally.
benchmarks.yml Registers new experiments/images for orchestration/costing.
benchmark_runner.py Adds script-id dispatch cases for the new benchmarks.
.github/workflows/push-containers-to-acr.yml Adds new services to the image build/push matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 7, 2026 10:11
@jathavaan jathavaan enabled auto-merge April 7, 2026 10:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jathavaan jathavaan merged commit 5977f91 into main Apr 7, 2026
32 checks passed
@jathavaan jathavaan disabled auto-merge April 7, 2026 10:33
@jathavaan jathavaan deleted the feature/171-implement-point-in-polygon-lookup-query branch April 7, 2026 10:33
@jathavaan jathavaan restored the feature/171-implement-point-in-polygon-lookup-query branch April 7, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement point-in-polygon lookup query

2 participants