Fix/351 config validation and readme corrections#354
Merged
jathavaan merged 2 commits intoMay 26, 2026
Conversation
jathavaan
force-pushed
the
fix/351-config-validation-and-readme-corrections
branch
from
74a468c to
c5b6bee
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Azure Log Analytics Workspace support by wiring workspace credentials into configuration, Azure Container Instances (ACI) creation, the CI workflow, and the README so benchmark containers can be provisioned with Log Analytics integration.
Changes:
- Added
AZURE_LOG_ANALYTICS_WORKSPACE_ID/AZURE_LOG_ANALYTICS_WORKSPACE_KEYtoConfig. - Updated orchestrator container creation logic to pass Log Analytics flags to
az container create. - Updated GitHub Actions workflow and README to document/provide the new variables/secrets.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/config.py |
Adds optional config fields for Log Analytics workspace ID/key. |
main.py |
Passes Log Analytics flags when creating benchmark containers via Azure CLI. |
.github/workflows/run-benchmarks.yml |
Supplies workspace ID/key to the orchestrator container creation step. |
README.md |
Documents the new env vars and GitHub Actions secrets/variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+390
to
396
| "--log-analytics-workspace", | ||
| Config.AZURE_LOG_ANALYTICS_WORKSPACE_ID, | ||
| "--log-analytics-workspace-key", | ||
| Config.AZURE_LOG_ANALYTICS_WORKSPACE_KEY, | ||
| "--no-wait", | ||
| ] | ||
|
|
Comment on lines
+390
to
394
| "--log-analytics-workspace", | ||
| Config.AZURE_LOG_ANALYTICS_WORKSPACE_ID, | ||
| "--log-analytics-workspace-key", | ||
| Config.AZURE_LOG_ANALYTICS_WORKSPACE_KEY, | ||
| "--no-wait", |
Comment on lines
+30
to
+35
| AZURE_LOG_ANALYTICS_WORKSPACE_ID: str = os.getenv( | ||
| "AZURE_LOG_ANALYTICS_WORKSPACE_ID", "" | ||
| ) | ||
| AZURE_LOG_ANALYTICS_WORKSPACE_KEY: str = os.getenv( | ||
| "AZURE_LOG_ANALYTICS_WORKSPACE_KEY", "" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for integrating Azure Log Analytics Workspace credentials into the application's configuration, deployment scripts, and documentation. The changes ensure that the necessary environment variables and secrets for Log Analytics are handled consistently across local development, GitHub Actions workflows, and runtime configuration.
Azure Log Analytics integration:
AZURE_LOG_ANALYTICS_WORKSPACE_IDandAZURE_LOG_ANALYTICS_WORKSPACE_KEYas optional environment variables in theConfigclass insrc/config.py.main.pyto pass the Log Analytics workspace ID and key as command-line arguments.GitHub Actions workflow updates:
.github/workflows/run-benchmarks.ymlto includeAZURE_LOG_ANALYTICS_WORKSPACE_KEYas a secret, pass the Log Analytics workspace ID and key to the container instance, and set them as environment variables for the workflow. [1] [2]Documentation updates:
README.mdto document the new environment variables, secrets, and workflow variables required for Azure Log Analytics integration. [1] [2] [3]