Skip to content

Refactor/361 remove all tile related code pmtiles mvt vmt#362

Merged
jathavaan merged 25 commits into
mainfrom
refactor/361-remove-all-tile-related-code-pmtiles-mvt-vmt
May 27, 2026
Merged

Refactor/361 remove all tile related code pmtiles mvt vmt#362
jathavaan merged 25 commits into
mainfrom
refactor/361-remove-all-tile-related-code-pmtiles-mvt-vmt

Conversation

@jathavaan
Copy link
Copy Markdown
Collaborator

This pull request removes all code, documentation, and configuration related to the "VMT API Server" and vector tile serving (PMTiles/MVT), streamlining the codebase to focus on the core benchmarking framework. It deletes the API server's Dockerfile and its service definition, removes related CI/CD workflows, and cleans up interfaces and documentation for tile APIs and vector tile formats.

Major removals and cleanup:

API server and vector tile serving:

  • Removed the vmt-api-server service from docker-compose.yml, deleting its build and run configuration.
  • Deleted the .docker/Api.Dockerfile used to build the API server container image.
  • Removed the entire GitHub Actions workflow for building, publishing, and deploying the API server (.github/workflows/publish-api.yml).
  • Eliminated the API server build job and related path filters from the main pull request CI workflow (.github/workflows/pull-request-tests.yml). [1] [2] [3]

Tile-related interfaces and contracts:

  • Removed IMVTService, ITileApiService, and ITileService interfaces and their imports from the application contracts, as well as the convert_pmtiles_to_bytes method from IBytesService. [1] [2] [3] [4]

Documentation updates:

README and architecture docs:

  • Updated README.md and CLAUDE.md to remove references to the VMT API server, PMTiles, and MVT vector tiles, focusing documentation on the remaining supported engines (DuckDB, PostGIS, Apache Sedona, and Shapefile). [1] [2] [3] [4] [5] [6]

These changes significantly simplify the project by removing unused vector tile serving infrastructure and related documentation, reducing maintenance overhead and clarifying the project's scope.

@jathavaan jathavaan self-assigned this May 27, 2026
Copilot AI review requested due to automatic review settings May 27, 2026 09:00
@jathavaan jathavaan linked an issue May 27, 2026 that may be closed by this pull request
@jathavaan jathavaan enabled auto-merge May 27, 2026 09:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the VMT API server and all vector-tile-related code paths (PMTiles/MVT), narrowing the repository’s scope back to the core benchmarking framework (DuckDB/PostGIS/Sedona/Shapefile).

Changes:

  • Deleted the FastAPI-based tile server endpoint and its Docker/CI plumbing (compose service, API Dockerfile, publish workflow, PR build job).
  • Removed tile-related application contracts and infrastructure services (MVT/PMTiles/tile selection), plus DI container wiring.
  • Cleaned up configuration/enums/dependencies/docs to eliminate tile-specific settings, containers, iterations, and library requirements.

Reviewed changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/presentation/entrypoints/setup_benchmarking_framework.py Removes PMTiles/MVT generation and tile-candidate probing logic from framework setup.
src/presentation/endpoints/tile_server.py Deletes the FastAPI VMT tile server implementation.
src/presentation/configuration/app_config.py Stops DI wiring for the removed tile server module.
src/infra/infrastructure/services/tile_service.py Deletes tile coordinate/tiles.json helper service.
src/infra/infrastructure/services/tile_api_service.py Deletes VMT/PMTiles fetching and PMTiles HTTP range reader helper.
src/infra/infrastructure/services/mvt_service.py Deletes PostGIS ST_AsMVT tile generation service.
src/infra/infrastructure/services/bytes_service.py Removes PMTiles file-to-bytes helper.
src/infra/infrastructure/services/__init__.py Removes exports for the deleted tile/MVT services.
src/infra/infrastructure/containers.py Removes DI providers and imports for tile/MVT services.
src/domain/enums/storage_container.py Removes the TILES storage container enum value.
src/domain/enums/benchmark_iteration.py Removes vector-tile benchmark iteration presets.
src/config.py Removes VMT server URL and local PMTiles/MVT resource paths/constants.
src/application/contracts/*tile* + *mvt* Deletes tile-related service interfaces and removes them from contracts exports.
requirements.txt Drops FastAPI/Starlette/Uvicorn and PMTiles-related dependencies.
README.md / CLAUDE.md Removes documentation references to VMT/PMTiles/MVT and web-app deployment steps.
docker-compose.yml Removes the vmt-api-server service.
.github/workflows/pull-request-tests.yml Removes API change detection output and the API image build job.
.github/workflows/publish-api.yml Deletes the API publish/deploy workflow.
.docker/Api.Dockerfile Deletes the API server Dockerfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jathavaan jathavaan disabled auto-merge May 27, 2026 09:13
@jathavaan jathavaan merged commit 444d770 into main May 27, 2026
24 checks passed
@jathavaan jathavaan deleted the refactor/361-remove-all-tile-related-code-pmtiles-mvt-vmt branch May 27, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all tile-related code (PMTiles, MVT, VMT)

2 participants