Merged
Conversation
CodSpeed Performance ReportMerging this PR will improve performance by 17.99%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | pydantic |
9.5 s | 8.1 s | +17.99% |
Project Diff ResultsView diff4c4
< test result: FAILED. 379 passed; 30 failed; 4 skipped
---
> test result: FAILED. 377 passed; 32 failed; 4 skipped
6c6
< test result: FAILED. 10590 passed; 476 failed; 377 skipped
---
> test result: FAILED. 8686 passed; 1435 failed; 265 skipped
8c8
< test result: FAILED. 240 passed; 16 failed; 3 skipped
---
> test result: FAILED. 240 passed; 11 failed; 3 skippedNew outputs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using
requestcan be useful, but with the added complexity to the codebase, I don't think it's important to supportTest Plan
Removed related tests.