Replace real-world benchmarks with custom benchmark project #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add karva-benchmark-1 as the single benchmark project from https://github.com/karva-dev/karva-benchmark-1 - Remove all previous real-world project benchmarks (affect, pydantic, pydantic-settings, sqlmodel, typer) - Use codspeed-macro runner for walltime benchmarks - Add actionlint.yaml to configure the codspeed-macro runner label Closes #390 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move rustup update before rust-cache to ensure Rust is updated before the cache action runs cargo metadata. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Project Diff ResultsNo changes between this PR and main. |
Previously, projects with no dependencies would early-return and skip installing the karva wheel and project root. This caused benchmarks to fail with "Could not find karva_core binary". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CodSpeed Performance ReportMerging this PR will create unknown performance changesComparing Summary
Performance Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
karva-benchmark-1as the single benchmark project from https://github.com/karva-dev/karva-benchmark-1codspeed-macrorunner for walltime benchmarksactionlint.yamlto configure thecodspeed-macrorunner labelCloses #390
Test plan
prek run -apassesjust testpasses (311 tests)🤖 Generated with Claude Code