Add inline snapshots (insta-style)#450
Merged
MatthewMckee4 merged 3 commits intomainfrom Feb 10, 2026
Merged
Conversation
Inline snapshots let users embed expected values directly in test source files via `karva.assert_snapshot(value, inline="")`. On first run or mismatch with `--snapshot-update`, the source file is rewritten in-place. Without `--snapshot-update`, a `.snap.new` file with inline metadata is created so `karva snapshot accept` can rewrite the source later. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CodSpeed Performance ReportMerging this PR will not alter performanceComparing
|
Rewrite find_inline_argument to bound search within the assert_snapshot() call using paren-depth tracking, preventing false matches on later calls. Add find_keyword_in_call to skip string literals/comments. Remove dead code, fix O(n²) dedent, refactor duplicated frame logic, add roundtrip test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
karva.assert_snapshot(value, inline="")where expected values live directly in test source files--snapshot-update, or.snap.newfiles with inline metadata are created forkarva snapshot acceptkarva_snapshot::inlinemodule handles dedenting, string literal generation, source scanning, and file rewritingTest plan
just testpasses (521 tests)prek run -apasses🤖 Generated with Claude Code