kas-text update; use child Role::TextRun for input fields#528
Merged
Conversation
|
At least for now and on Windows, all text inputs appear as empty to screen readers even if they are not, and moving the caret report nothing. Perhaps more interestingly at this stage, I've noticed a delay when tabbing into a text input. |
52b523a to
0aa4402
Compare
Collaborator
Author
|
I don't understand what's going on there. There shouldn't be a delay; if anything AccessKit info is updated far too often in the current code. All text inputs should get their contents set via a |
51ea5bd to
b99964a
Compare
Collaborator
Author
|
I removed |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates kas-text corresponding to kas-gui/kas-text#98.
Adds
Role::AccesskitVerbatimand uses it to report the text in anEditFieldas specified here, save that character and word data is not provided (requires more extensivekas-textchanges I don't wish to work on since in my opinion AccessKit should query existing text objects for this kind of detail instead of using its own algorithms over character-level reconstructions).This is a hack and hopefully will be replaced eventually.
In my testing, the screen reader can now read
SpinBoxvalues but notEditBoxvalues;I don't know why but the only difference visible to AccessKit should be what the parent node is (Role::SpinButtonin the former case,Role::ScrollViewin the latter case). CC @DataTrinySpinBoxalready has a numerical value set.