Add widget Page, Role::TabPage, use HasId in fn depress_with_key#540
Merged
Add widget Page, Role::TabPage, use HasId in fn depress_with_key#540
Conversation
Stack and TabStack are now templated over input data, forcing usage of Box<dyn Widget> in Page.
dhardy
force-pushed
the
push-ptlpwqwuvvol
branch
from
9723326 to
e31d9f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
Pagewidget withRole::TabPageand use inStack.Use
HasIdinfn depress_with_key. Usage ofHasIdremains inconsistent, but usage here saved enough.id()calls that it seems worthwhile.