SelectableText → ScrollTextCore; EditField → EditBoxCore#683
Merged
Conversation
Since SelectableText does not have scroll support, let's rename it ScrollTextSomething lol and what if someone is looking for selectable non-scrolling text or scrolling non-selectable text? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
SelectableTextandEditFielddo not have scroll support they are best not used except as a child of another widget which manages their scroll behaviour (i.e.ScrollText,EditBox). The renames help emphasize this. (Further renaming before the next release is possible; internal moduleedit_fieldis not renamed for now.)The property
editableis replaced withread_only(an inversion: slightly clearer and aligns the default behaviour with the default boolean valuefalse).Add fn
EditBox::with_frame_style; use inexamples/splitter.rsinstead ofEditField. Motivation:EditFieldshould not have been used here since it does not support scrolling. This is somewhat of a hack; ideally frames and margins will be reworked to avoid drawing "box" boundaries next to a visual divider likeGripPart.