KASM-8279-Fixing watermark issue leading to black screen#180
Merged
Conversation
mmcclaskey
approved these changes
Apr 12, 2026
baldvin-kovacs
pushed a commit
to baldvin-kovacs/noVNC
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the new encoding/decoding methods are being added to KasmVNC, an update to simplify the decoding process in noVNC can lead to the watermark overlay feature failing to work properly and lead to a black/blank screen getting presented to users. Looks like the issue was introduced in core/display.js during the first round of VNC-151 h.264 h.265 and av1 video encoding updates (commit 51da79d).