Fix stubbing of callable module descriptors like numpy.vstack#120
Merged
Fix stubbing of callable module descriptors like numpy.vstack#120
Conversation
When validating method stubs, callable objects exposing __get__ were treated as non-callable to keep class-descriptor attributes on the property stubbing path. NumPy's _ArrayFunctionDispatcher (used by `np.vstack`) matches that shape, so method stubbing regressed with "is not callable". Pass the active spec into _should_continue_with_stubbed_invocation() and compute descriptor handling inside the helper. Keep the class-spec behavior, but allow callable descriptor-like values for non-class specs (e.g. modules). Add a numpy regression test that stubs np.vstack. Ref #119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validating method stubs, callable objects exposing get were treated as non-callable to keep class-descriptor attributes on the property stubbing path. NumPy's _ArrayFunctionDispatcher (used by
np.vstack) matches that shape, so method stubbing regressed with "is not callable".Pass the active spec into _should_continue_with_stubbed_invocation() and compute descriptor handling inside the helper. Keep the class-spec behavior, but allow callable descriptor-like values for non-class specs (e.g. modules).
Add a numpy regression test that stubs np.vstack.
Ref #119