Harden provider startup handshake protocol#30
Merged
Conversation
…capture, and tests - waitForReady now races 3 signals (like Terraform go-plugin): stdout line, process exit, timeout - Stderr captured via io.MultiWriter and included in error messages for diagnostics - Remove committed binary artifact (dstream) - Add CI workflow for unit tests - 10 tests covering: ready, error, crash, timeout, legacy, stderr context, mid-stream crash, data relay, graceful shutdown, stderr during operation Closes #24, closes #25, closes #26 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForReadynow races 3 signals (modeled after Terraform's go-plugin): first stdout line, process exit, and timeout. Previously a crashed provider would block for the full 30s timeout.io.MultiWriterduring startup and included in error messages, so crash diagnostics are immediately visible.dstreambinary artifactTest cases
{"status":"ready"}Closes #24, closes #25, closes #26
Test plan
🤖 Generated with Claude Code