fix: update radare2 download source to GitHub releases#444
fix: update radare2 download source to GitHub releases#444kavishdevar merged 1 commit intokavishdevar:mainfrom
Conversation
📝 WalkthroughWalkthroughThis pull request updates radare2 download URLs from legacy sources to GitHub releases across two files. The Kotlin utility updates a URL constant, while the Magisk module build script updates its download command to use the aln variant of radare2. Changes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
devnoname120
left a comment
There was a problem hiding this comment.
Dead links are the reason I initially just committed the tarball in the repo directly 😄
For reference here is why we need to use a custom radare2 build: devnoname120/radare2@5459930
fix(radare2): update radare2 download url
This PR updates the download URL for the
radare2binary used in both the Android application and the Magisk module build script.The previous
your-objectstorage.comlinks have become unreliable or offline, leading to the setup failures reported by multiple users in #439. This change migrates the source to official GitHub release assets provided bydevnoname120(5.9.8-android-aln), i hope that is the correct one.Changes
RadareOffsetFinder.kt: UpdatedRADARE2_URLto point to the new GitHub release asset.build-magisk-module.sh: Updated thecurltarget to ensure the Magisk module builds with a valid binary.Linked Issues
Testing & Verification
Important
Partial Verification: I have verified that the new URLs are reachable and the files are being pulled correctly. However, I am currently unable to perform a full end-to-end connection test due to the ongoing L2CAP connection issues on the Pixel 7a (as documented in #229).
Despite the socket timeout/PSM issues on my specific hardware, this PR successfully fixes the installation phase of the setup, which was previously failing for everyone.
Summary by CodeRabbit