Phase 3: OpNode#2
Merged
Merged
Conversation
… service discovery details for L2 connectivity, and refactor getSequencerEndpoint function in statefulset.go to support dynamic endpoint resolution. This improves configuration management and clarifies the separation of L1 and L2 responsibilities.
…nerated and user-provided private keys. Update volume and mount configurations to reflect the new logic for determining secret names based on key management method.
…C port configuration.
…atus fields during updates, improving race condition handling.
…after secrets and StatefulSet readiness, improving status management and logging for errors during updates.
There was a problem hiding this comment.
Bug: Replica Nodes Fail to Connect Due to Incorrect Endpoint
The getSequencerEndpoint function incorrectly constructs the sequencer endpoint for replica nodes. It hardcodes the HTTP port to 8545, ignoring the configurable opNode.Spec.OpGeth.Networking.HTTP.Port. Additionally, it assumes a sequencer service name of {network.Name}-sequencer, while OpNode services are actually named after the opNode.Name. This results in replica nodes failing to connect to the sequencer.
pkg/resources/statefulset.go#L514-L525
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.