Publish with jitpack.io #15
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=========================================
Coverage 92.38% 92.38%
Complexity 111 111
=========================================
Files 9 9
Lines 289 289
Branches 48 48
=========================================
Hits 267 267
Misses 20 20
Partials 2 2 ☔ View full report in Codecov by Sentry. |
briehl
left a comment
briehl
left a comment
There was a problem hiding this comment.
Looks good, just a comment about some of the text of the readme that could be more clear.
README.md
Outdated
|
|
||
| ## Usage | ||
|
|
||
| If backwards compatibility with old code is required, use the |
There was a problem hiding this comment.
How old? Got a date estimate? Or other way of saying how old?
briehl
left a comment
briehl
left a comment
There was a problem hiding this comment.
Looks good, all the jitpack links seem to work fine, too. LGTM!
|
|
||
| ## Usage | ||
|
|
||
| If backwards compatibility with versions of the client prior to 0.5.0 is required, use the |
|
|
||
| For example: | ||
|
|
||
| https://javadoc.jitpack.io/com/github/kbase/auth2_client_java/0.5.0/javadoc/ |
There was a problem hiding this comment.
I got Tag or commit '0.5.0' not found. Rechecking.
There was a problem hiding this comment.
Yep, there's no 0.5.0 release yet - that'll be the first release.
|
|
||
| ## Prior version | ||
|
|
||
| The prior version of the client is available at https://github.com/kbase/auth for source code |
There was a problem hiding this comment.
I thought auth2 is a more recent version of auth. Both auth2 and auth contain client code as well as server code?
There was a problem hiding this comment.
auth contains (mostly out of date) client code and no server code.
auth2 contains the auth server code
| /** | ||
| * Set the lifetime of a string in the cache. | ||
| * @param seconds the lifetime of a string | ||
| * @param seconds the lifetime of a string. |
There was a problem hiding this comment.
Some of java docs end with . while others don't.
There was a problem hiding this comment.
I'll fix that the next time I make changes
No description provided.