Merged
Conversation
The tests pass with or without the changes in this commit in the docker container, which is UTC, but fail without the changes on my laptop, which is not UTC. The problem is that `datetime.utcnow()` is not timezone aware, so it only works on UTC systems.
Collaborator
|
@MrCreosote It should probably be "time.time()" in order to match the other timestamps |
Member
Author
|
@bio-boris updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
The tests pass with or without the changes in this commit in the docker
container, which is UTC, but fail without the changes on my laptop, which is
not UTC.
The problem is that
datetime.utcnow()is not timezone aware, so itonly works on UTC systems.
Jira Ticket / Github Issue
Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)