Merged
Conversation
Tests pass locally
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #62 +/- ##
=============================================
+ Coverage 37.91% 39.34% +1.42%
Complexity 333 333
=============================================
Files 34 30 -4
Lines 3067 2956 -111
Branches 535 516 -19
=============================================
Hits 1163 1163
+ Misses 1757 1646 -111
Partials 147 147 |
Xiangs18
reviewed
Apr 11, 2024
| public void detectEncoding() throws Exception { | ||
| for (String data: basicJsonData) { | ||
| for (Charset enc: encodings) { | ||
| @SuppressWarnings("resource") |
Contributor
There was a problem hiding this comment.
Could you please explain more when we need this and why you are deleting it?
Member
Author
There was a problem hiding this comment.
It just quiets a compiler warning. I'm deleting it because eclipse is telling me it's not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests pass locally