Skip to content

Conversation

@MrCreosote
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

# run workflow when merging to main or develop
branches:
- main
- master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need "master"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not, it's just boilerplate from a zillion other repos. Removed

- name: Install dependencies
shell: bash
run: |
export UV_PROJECT_ENVIRONMENT="${pythonLocation}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this set and why is it needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's set by the GHA machinery. It tells uv to install everything to the system vs. a venv.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use it in dockerfiles frequently


- name: Run tests
shell: bash
run: PYTHONPATH=src pytest --cov=src --cov-report=xml test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be uv run pytest...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the export above this works

@MrCreosote MrCreosote merged commit ada71be into main Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants