Special Chars for Fulltext Search#103
Merged
4 commits merged intodevelopfrom Mar 21, 2022
Merged
Conversation
ghost
requested a review
from 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For changes to the codebase:
The FULLTEXT search has some special escape characters, e.g.,
,,+,-,|,:,",'. Add some tests for any special character that has not already been tested and exists in ancbi_taxonsciname. (Note this is a bare minimum test, because the search could behave differently within a vaster collection of scinames, and depending on the syntax context of the special escape char.)