Update dependencies#157
Merged
MrCreosote merged 2 commits intodevelopfrom Jul 28, 2022
Merged
Conversation
... or alternately, sthu dependabot
MrCreosote
commented
Jul 27, 2022
| flake8==4.0.1 | ||
| grequests==0.3.0 | ||
| coverage==5.2.1 | ||
| typed-ast>=1.4.0 |
Member
Author
There was a problem hiding this comment.
Not needed in python 3.8+
MrCreosote
commented
Jul 27, 2022
| typed-ast>=1.4.0 | ||
| black==22.3.0 | ||
| pytest==6.2.5 | ||
| jinja2==3.0.3 |
Member
Author
There was a problem hiding this comment.
Already in requirements.txt
MrCreosote
commented
Jul 27, 2022
| """ | ||
| from jsonschema import validators, Draft7Validator, FormatChecker, RefResolver | ||
|
|
||
| from jsonschema.compat import ( |
Member
Author
There was a problem hiding this comment.
jsonschema.compat was an internal-only API and was removed in 4.X (without a mention in the release notes either...)
There was a problem hiding this comment.
Hmm I tried to do this before and ran into errors
There was a problem hiding this comment.
Okay you got the functions from somewhere else. Nice.
ghost
reviewed
Jul 28, 2022
| else: | ||
| # Otherwise, pass off to urllib and assume utf-8 | ||
| with urlopen(uri) as url: | ||
| # TODO https://github.com/kbase/relation_engine/issues/156 |
There was a problem hiding this comment.
Seems like this is for the remote specs loading that we don't even use? Maybe? If so, YAGNI for now
ghost
reviewed
Jul 28, 2022
| # run importer/, relation_engine_server/, and spec/ tests | ||
| coverage run --branch -m pytest | ||
| # RE client tests - seemss like these tests were already run in the line above, why run them again? | ||
| # RE client tests - seems like these tests were already run in the line above, why run them again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... or alternately, sthu dependabot
This was much more of a pain than I expected when I started on it.
Also see #156
For changes to the codebase: