Skip to content

Update collection specs for species_or_below field#165

Merged
MrCreosote merged 1 commit intodevelopfrom
dev-update_specs
Aug 5, 2022
Merged

Update collection specs for species_or_below field#165
MrCreosote merged 1 commit intodevelopfrom
dev-update_specs

Conversation

@MrCreosote
Copy link
Copy Markdown
Member

@MrCreosote MrCreosote commented Aug 5, 2022

Relevant loader PRs:
kbase/relation_engine_importers#57
kbase/relation_engine_importers#55

  • I updated the README.md docs to reflect this change.

For changes to the codebase:

  • [n/a] I have written tests to cover this change.
  • This is not a breaking API change OR
  • This is a breaking API change and I have incremented the API version and added a summary to CHANGELOG.md.

@MrCreosote MrCreosote requested a review from a user August 5, 2022 20:39
description: DEPRECATED. See https://github.com/kbase/relation_engine_importers/blob/29cbf68b289335ec5c27201efba0058a501c6b74/docs/NCBI_taxa_sciname_lookup_issues_22_07.md
This field should not be used in any new code, but is left intact as it may be contained in
already loaded data.
Original description was
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use a colon here but that makes Original description was a jsonschema field

@MrCreosote
Copy link
Copy Markdown
Member Author

MrCreosote commented Aug 5, 2022

Re the trivy scan, it seems like alpine doesn't have the fix ready yet...? Not super familiar with alpine
https://pkgs.alpinelinux.org/package/edge/main/x86/libtirpc

@MrCreosote MrCreosote merged commit 0f253f9 into develop Aug 5, 2022
@MrCreosote MrCreosote deleted the dev-update_specs branch August 5, 2022 20:57
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants