Skip to content

Add release date prior to merge to master#166

Merged
MrCreosote merged 1 commit intodevelopfrom
dev-update_specs
Aug 15, 2022
Merged

Add release date prior to merge to master#166
MrCreosote merged 1 commit intodevelopfrom
dev-update_specs

Conversation

@MrCreosote
Copy link
Copy Markdown
Member

Changes have been running in CI since the 5th

  • [n/a] I updated the README.md docs to reflect this change.

For changes to the codebase:

  • [n/a] I have written tests to cover this change.
  • This is not a breaking API change OR
  • This is a breaking API change and I have incremented the API version and added a summary to CHANGELOG.md.

@MrCreosote MrCreosote requested a review from a user August 15, 2022 20:02
@MrCreosote MrCreosote merged commit cb86258 into develop Aug 15, 2022
@MrCreosote MrCreosote deleted the dev-update_specs branch August 15, 2022 20:07
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this its own separate PR? And it's not even in the dev->main PR?
Edit: Oh, because develop is a protected branch

@MrCreosote
Copy link
Copy Markdown
Member Author

Why is this its own separate PR?

Which PR were you thinking it should be included in? Neither of the other two I did yesterday seemed appropriate to me

And it's not even in the dev->main PR?

It is though?
https://github.com/kbase/relation_engine/pull/167/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR8

@ghost
Copy link
Copy Markdown

ghost commented Aug 16, 2022

Sorry, ignore what I said. I almost immediately added an "Edit:" to my previous comment, saying that I realized you did this because develop is a protected branch. So you have to PR any random stuff in.

@MrCreosote
Copy link
Copy Markdown
Member Author

I never push directly to develop or master for any kbase repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants