RE2022-278 RE2022-280 add basic histogram and scatter#133
Merged
dakotablair merged 10 commits intomainfrom Mar 4, 2024
Merged
Conversation
dauglyon
changed the title
Collaborator
Author
|
The scatter plot is disappearing on zoom; it needs to be fixed before merging. Also, check the issue for scroll formatting. |
codytodonnell
approved these changes
Feb 28, 2024
Collaborator
codytodonnell
left a comment
codytodonnell
left a comment
There was a problem hiding this comment.
Looks fantastic!
I am having an issue installing the new dependencies locally. This appears to be specific to my local environment and is caused by the canvas dev dependency. See relevant thread: Automattic/node-canvas#1773 (comment)
dakotablair
approved these changes
Mar 4, 2024
Collaborator
dakotablair
left a comment
dakotablair
left a comment
There was a problem hiding this comment.
We may be able to fix the canvas build problems with the suggestions in node-canvas issue #2353.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also solves the following bug punchlist issues:
Investigate 2d histogram failure states
Better loading state (same size as graph)
Data loading issue, keys are different between gtdb and enigma, should be solved before deploy
Need to special case for GTDB