Conversation
There was a problem hiding this comment.
This all looks good. The only issue I'm seeing locally is that the scrollbar bugs out in the modal while the match is processing. I'm not sure if this is related to a change you made or not. I could merge your changes into the modal cleanup branch though and handle the issue there.
I also don't have any read-only narratives so I can't confirm that feature. However I am not seeing any narratives in the export menu which could be a good sign.
|
During a match or during export? I only changed the export modal so I'm assuming the latter? Can you screencap and share? |
|
Also just realized I committed with my error image code changes still there ("badtype") |
|
Hmm yeah, shouldn't be this branch which is causing that. Is main different for you? I can't reproduce |
|
I'm seeing it on other branches too so it must be coming from somewhere else. |

fixes three punchlist bugs:
Don’t show read-only narratives in the export select boxExport form needs improved error statesIn export GUI, Data Object Name -> New [Genome | Assembly] Set Object Namealso fixes input blur/focus handler forwarding and disables the export button in the select modal when there is no selection.
New form states:
Success
Validation Error
Server Error (forced this error because I couldn't figure out a valid form state that lead to a server error)