Skip to content

Fix Export Form#169

Merged
dauglyon merged 4 commits intomainfrom
fix-export-form
Mar 12, 2024
Merged

Fix Export Form#169
dauglyon merged 4 commits intomainfrom
fix-export-form

Conversation

@dauglyon
Copy link
Copy Markdown
Collaborator

@dauglyon dauglyon commented Mar 11, 2024

fixes three punchlist bugs:

  • Don’t show read-only narratives in the export select box
  • Export form needs improved error states
  • In export GUI, Data Object Name -> New [Genome | Assembly] Set Object Name

also fixes input blur/focus handler forwarding and disables the export button in the select modal when there is no selection.

New form states:

Success

Screenshot 2024-03-11 at 3 20 52 PM

Validation Error

Screenshot 2024-03-11 at 4 06 14 PM

Server Error (forced this error because I couldn't figure out a valid form state that lead to a server error)

Screenshot 2024-03-11 at 3 29 49 PM

Copy link
Copy Markdown
Collaborator

@codytodonnell codytodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. The only issue I'm seeing locally is that the scrollbar bugs out in the modal while the match is processing. I'm not sure if this is related to a change you made or not. I could merge your changes into the modal cleanup branch though and handle the issue there.

I also don't have any read-only narratives so I can't confirm that feature. However I am not seeing any narratives in the export menu which could be a good sign.

@dauglyon
Copy link
Copy Markdown
Collaborator Author

During a match or during export? I only changed the export modal so I'm assuming the latter? Can you screencap and share?

@dauglyon
Copy link
Copy Markdown
Collaborator Author

Also just realized I committed with my error image code changes still there ("badtype")

@codytodonnell
Copy link
Copy Markdown
Collaborator

During a match or during export? I only changed the export modal so I'm assuming the latter? Can you screencap and share?

Screenshot 2024-03-11 at 5 13 02 PM

It's in the match modal. The scrollbar expands and detracts while loading

@dauglyon
Copy link
Copy Markdown
Collaborator Author

Hmm yeah, shouldn't be this branch which is causing that. Is main different for you? I can't reproduce

@codytodonnell
Copy link
Copy Markdown
Collaborator

I'm seeing it on other branches too so it must be coming from somewhere else.

@dauglyon dauglyon merged commit 20935b7 into main Mar 12, 2024
@dauglyon dauglyon deleted the fix-export-form branch March 12, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants