Conversation
dakotablair
approved these changes
Mar 19, 2024
Collaborator
dakotablair
left a comment
dakotablair
left a comment
There was a problem hiding this comment.
It's about time! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of changes moves the codebase from requirement to use node 16 to a requirement to use node 20, the current recommended LTS release. Node 16 is out of maintenance and will receive no further updates AFAIK, security or otherwise.
The version chosen is the current release of node 20 at this point in time.
There are, surprisingly, minimal changes to support this. The package lock file, for instance, is unchanged other than the engines property. Tests run fine.
This also allows using node 20 base images, which contain far fewer CVEs than the node 20 ones.