Load config from environment in load_config#74
Merged
yuvipanda merged 1 commit intokbatch-dev:mainfrom Sep 16, 2024
Merged
Conversation
minrk
force-pushed
the
load-config-env
branch
from
72f1066 to
446aa93
Compare
less repetition of load priority
minrk
force-pushed
the
load-config-env
branch
from
446aa93 to
f4bc451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consolidates config file > env priority in one place, less repetition of
token or config["token"] or env["JUPYTERHUB_API_TOKEN"]