-
-
Notifications
You must be signed in to change notification settings - Fork 236
Refactor to PSR-4 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've been out of the world of PHP for a while now, so I'm kind of learning how to.. read again. But this mostly all looks like pretty straight-forward good stuff, and I'm inclined to pull it in. You mentioned hoping to get the library published, is there anything more that you need beyond these changes to make that happen? |
|
@kbjr Thanks for considering my PR. Well, I want to use this in one of my projects and I would like to add it with composer, there needs to be some configuration in the repo and packagist.com in order to accomplish this. If you like I could take care of this is you give me temporary access to the configuration of this repo and collaboration access. Also I notice you had a |
|
Hey there @kbjr, is there anything I can do to help on this? or have you decided not to merge it? Thanks in advance. |
|
That docs page was old / outdated. If you would like to create new docs, I would be perfectly happy to pull those in as well. |
The PR that was made in [kbjr/Git.php](kbjr/Git.php#65) also changed the name of the methods on the `GitRepo` class.
The PR that was made in [kbjr/Git.php](kbjr/Git.php#65) also changed the name of the methods on the `GitRepo` class.
This PR refactor the code: