Skip to content

Conversation

@adrorocker
Copy link
Contributor

This PR refactor the code:

  • To be in compliance with PSR-4
  • To be in compliance with PSR-1 at least.
  • Prepare to, hopefully, publish this code in packagist.org

@kbjr
Copy link
Owner

kbjr commented Apr 28, 2021

I've been out of the world of PHP for a while now, so I'm kind of learning how to.. read again. But this mostly all looks like pretty straight-forward good stuff, and I'm inclined to pull it in.

You mentioned hoping to get the library published, is there anything more that you need beyond these changes to make that happen?

@adrorocker
Copy link
Contributor Author

@kbjr Thanks for considering my PR. Well, I want to use this in one of my projects and I would like to add it with composer, there needs to be some configuration in the repo and packagist.com in order to accomplish this. If you like I could take care of this is you give me temporary access to the configuration of this repo and collaboration access.

Also I notice you had a gh-pages branch to host the documentation. Now you can just have the same "main" branch to serve the docs directory in https://kbjr.github.io/Git.php/ I was about to update the repo with that too but not sure what you were using to generate it. I can take care of that too if you like.

@adrorocker
Copy link
Contributor Author

Hey there @kbjr, is there anything I can do to help on this? or have you decided not to merge it?

Thanks in advance.

@kbjr
Copy link
Owner

kbjr commented Apr 30, 2021

That docs page was old / outdated. If you would like to create new docs, I would be perfectly happy to pull those in as well.

@kbjr kbjr merged commit 51d4438 into kbjr:master Apr 30, 2021
adrorocker added a commit to adrorocker/Gitify that referenced this pull request May 3, 2021
The PR that was made in [kbjr/Git.php](kbjr/Git.php#65) also changed the name of the methods on the `GitRepo` class.
Mark-H pushed a commit to modmore/Gitify that referenced this pull request May 3, 2021
The PR that was made in [kbjr/Git.php](kbjr/Git.php#65) also changed the name of the methods on the `GitRepo` class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants