Merged
Conversation
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
PrasadG193
reviewed
May 10, 2021
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
PrasadG193
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sahil-lakhwani sahilakhwani@gmail.com
Adds a template rendering engine to allow templated args for helm apps.
The args passed to helm app would be allowed to use all the template functions from the standard Go template library and the Sprig library.
There are some functions added from the Helm library called from here, and other two called "include" and "lookup"
Note that the values passed to the template itself have to be a constant, meaning - the args can't refer to any values from values.yaml
Example:
The value for
rbac.createis resolved to true only if there's a ServiceAccount namedadminpresent