Skip to content

Fix tests for 8.6#460

Merged
Art4 merged 7 commits intov2.xfrom
fix-php-8.6-tests
Feb 8, 2026
Merged

Fix tests for 8.6#460
Art4 merged 7 commits intov2.xfrom
fix-php-8.6-tests

Conversation

@Art4
Copy link
Copy Markdown
Collaborator

@Art4 Art4 commented Feb 8, 2026

PHP 8.6 will start to output more error details on decoding JSON. e.g. Syntax error will become Syntax error near location 1:12, so the tests for PHP 8.6 fails at the moment.

This PR will fix this.

See https://php.watch/versions/8.6/json_decode-error-position

@Art4 Art4 added this to the v2.9.0 milestone Feb 8, 2026
@Art4 Art4 self-assigned this Feb 8, 2026
@Art4 Art4 marked this pull request as draft February 8, 2026 08:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.52%. Comparing base (00d823f) to head (f67a8fc).
⚠️ Report is 8 commits behind head on v2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #460   +/-   ##
=========================================
  Coverage     98.52%   98.52%           
  Complexity      661      661           
=========================================
  Files            29       29           
  Lines          2031     2033    +2     
=========================================
+ Hits           2001     2003    +2     
  Misses           30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Art4 Art4 marked this pull request as ready for review February 8, 2026 20:37
@Art4 Art4 requested a review from kbsali February 8, 2026 20:38
@Art4 Art4 merged commit 63b0368 into v2.x Feb 8, 2026
25 checks passed
@Art4 Art4 deleted the fix-php-8.6-tests branch February 8, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants