Skip to content

Conversation

@Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 1, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #667

fix: argument type check on too many arguments for empty parameter list

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/arg.rs (remove params empty check)

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/args/schema_types_err_too_many_args_0/main.k
  • test/grammar/types/args/schema_types_err_too_many_args_1/main.k
  • test/grammar/types/args/schema_types_err_too_many_args_2/main.k

@Peefy Peefy added bug Something isn't working semantic Issues or PRs related to kcl semantic and checker labels Sep 1, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Sep 1, 2023
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy force-pushed the fix-arguments-ty-check branch from e9d8e84 to 8613e31 Compare September 1, 2023 07:54
@Peefy Peefy merged commit c2f3d87 into kcl-lang:main Sep 1, 2023
@Peefy Peefy deleted the fix-arguments-ty-check branch September 1, 2023 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working semantic Issues or PRs related to kcl semantic and checker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: the IDE failed to output the expected error.

3 participants