Allow to delete related object copies when the primary object is deleted#164
Open
xrstf wants to merge 5 commits intokcp-dev:mainfrom
Open
Allow to delete related object copies when the primary object is deleted#164xrstf wants to merge 5 commits intokcp-dev:mainfrom
xrstf wants to merge 5 commits intokcp-dev:mainfrom
Conversation
kcp-ci-bot
added
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kcp-ci-bot
added
dco-signoff: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new option to each RelatedResource, allowing the admin to configure whether the created copies of such related resources should be deleted when the primary object is deleted. By default we don't do this, in case for example a Secret was synced from the service cluster to kcp and is integrated there into other automation: we wouldn't want to break that automation.
But in some scenarios it can make sense to clean up, and this is what this PR enables.
This PR also includes a small improvement to make the RR Watches work if the RR is still using
Kind(i.e. GVK) instead of GVR.What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #114
Release Notes