Conversation
.gitignore
Outdated
| .checkpoint-** | ||
|
|
||
| .idea/ | ||
| ./20241013-kubecon-saltlakecity/mounts-vw/hack/tools/* |
There was a problem hiding this comment.
Create a separate .gitignore file in ./20241013-kubecon-saltlakecity/mounts-vw with hack/tools/ line instead.
|
Also consider adding a symlink into https://github.com/kcp-dev/contrib/tree/main/website/content/learning, and adding an entry into https://github.com/kcp-dev/contrib/blob/main/website/content/learning/index.md (btw there is a PR that also modifies that file: #23 ; I'm tempted we do it at once...). |
6507eaf to
3ce7a97
Compare
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: b907e1aff602dbd16bd96fa462cf55cce2482d9d |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a working updated mounts example from US Kubecon. Just updated to work with spec promoted mount and all the rest of the changed in kcp.