Skip to content

Add mounts VW example#24

Merged
mjudeikis merged 3 commits intokcp-dev:mainfrom
mjudeikis:mjudeikis/mounts.vw
Apr 29, 2025
Merged

Add mounts VW example#24
mjudeikis merged 3 commits intokcp-dev:mainfrom
mjudeikis:mjudeikis/mounts.vw

Conversation

@mjudeikis
Copy link
Contributor

This adds a working updated mounts example from US Kubecon. Just updated to work with spec promoted mount and all the rest of the changed in kcp.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2025
.gitignore Outdated
.checkpoint-**

.idea/
./20241013-kubecon-saltlakecity/mounts-vw/hack/tools/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a separate .gitignore file in ./20241013-kubecon-saltlakecity/mounts-vw with hack/tools/ line instead.

@gman0
Copy link
Contributor

gman0 commented Apr 28, 2025

Also consider adding a symlink into https://github.com/kcp-dev/contrib/tree/main/website/content/learning, and adding an entry into https://github.com/kcp-dev/contrib/blob/main/website/content/learning/index.md (btw there is a PR that also modifies that file: #23 ; I'm tempted we do it at once...).

@mjudeikis mjudeikis force-pushed the mjudeikis/mounts.vw branch from 6507eaf to 3ce7a97 Compare April 29, 2025 13:23
@gman0
Copy link
Contributor

gman0 commented Apr 29, 2025

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@kcp-ci-bot
Copy link

LGTM label has been added.

DetailsGit tree hash: b907e1aff602dbd16bd96fa462cf55cce2482d9d

@mjudeikis
Copy link
Contributor Author

/approve

@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@mjudeikis mjudeikis merged commit 44120d0 into kcp-dev:main Apr 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants