Conversation
Signed-off-by: Frederic Giloux <fgiloux@redhat.com>
|
Hi @fgiloux. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fgiloux, varshaprasad96 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@fgiloux: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
We are winding down the repo. |
It may be helpful to make the reader aware that an APIBinding needs to be created to consume the API provided by the example.
This PR adds a sentence about it in the readme and an example.
The name of the APIExport in the deployment is aligned with what is created by
make deploy.Signed-off-by: Frederic Giloux fgiloux@redhat.com