Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Add an example of an APIBinding#21

Closed
fgiloux wants to merge 1 commit intokcp-dev:mainfrom
fgiloux:apibinding
Closed

Add an example of an APIBinding#21
fgiloux wants to merge 1 commit intokcp-dev:mainfrom
fgiloux:apibinding

Conversation

@fgiloux
Copy link
Contributor

@fgiloux fgiloux commented Sep 1, 2022

It may be helpful to make the reader aware that an APIBinding needs to be created to consume the API provided by the example.
This PR adds a sentence about it in the readme and an example.
The name of the APIExport in the deployment is aligned with what is created by make deploy.

Signed-off-by: Frederic Giloux fgiloux@redhat.com

Signed-off-by: Frederic Giloux <fgiloux@redhat.com>
@openshift-ci openshift-ci bot requested review from davidfestal and sttts September 1, 2022 16:17
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2022

Hi @fgiloux. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgiloux, varshaprasad96
Once this PR has been reviewed and has the lgtm label, please assign stevekuznetsov for approval by writing /assign @stevekuznetsov in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fgiloux
Copy link
Contributor Author

fgiloux commented Oct 20, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2022

@fgiloux: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 28a4468 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2024
@sttts
Copy link
Member

sttts commented Apr 17, 2024

We are winding down the repo.

@sttts sttts closed this Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants