Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Bump libraries to v0.23.0#39

Closed
sttts wants to merge 1 commit intokcp-dev:mainfrom
sttts:sttts-bump
Closed

Bump libraries to v0.23.0#39
sttts wants to merge 1 commit intokcp-dev:mainfrom
sttts:sttts-bump

Conversation

@sttts
Copy link
Member

@sttts sttts commented Apr 2, 2024

No description provided.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2024
@ArangoGutierrez
Copy link

ArangoGutierrez commented Apr 2, 2024

Makefile requires bump

CONTROLLER_TOOLS_VERSION ?= v0.14.0
KCP_VERSION ?= 0.23.0

to prevent error during make build

@sttts
Bump libraries
6287b61 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
ArangoGutierrez
ArangoGutierrez approved these changes Apr 3, 2024
View reviewed changes
Copy link

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, I don't have lgtm permission here

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Apr 3, 2024

@ArangoGutierrez: changing LGTM is restricted to collaborators

Details

In response to this:

Works for me, I don't have lgtm permission here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Member Author

sttts commented Apr 3, 2024

/lgtm
/approve

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Apr 3, 2024

@sttts: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@sttts
Copy link
Member Author

sttts commented Apr 17, 2024

Replaced by kcp-dev/controller-runtime#51

@sttts sttts closed this Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sttts @ArangoGutierrez @kcp-ci-bot