This repository was archived by the owner on Apr 24, 2024. It is now read-only.
Merged
Conversation
- Use kubebuilder to initialize project - Add Widget API + controller - Update Makefile, readme to describe running on kcp Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
|
|
||
| .PHONY: vet | ||
| vet: ## Run go vet against code. | ||
| go vet ./... |
Contributor
There was a problem hiding this comment.
go test does this implicitly these days
Member
Author
There was a problem hiding this comment.
This was boilerplate from kubebuilder init
|
|
||
| // Include the clusterName from req.ObjectKey in the logger, similar to the namespace and name keys that are already | ||
| // there. | ||
| logger = logger.WithValues("clusterName", req.ObjectKey.Cluster.String()) |
Contributor
There was a problem hiding this comment.
Do we expect changes to controller-runtime making this unnecessary in user-code?
Member
Author
There was a problem hiding this comment.
Maaaaaybe but not in the immediate term
stevekuznetsov
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by/depends on: